Refactor error and response handling in Fastify plugins#77
Merged
mitchknife merged 2 commits intoFacilityApi:masterfrom Dec 11, 2025
Merged
Refactor error and response handling in Fastify plugins#77mitchknife merged 2 commits intoFacilityApi:masterfrom
mitchknife merged 2 commits intoFacilityApi:masterfrom
Conversation
- Introduced `sendResponse` and `sendErrorResponse` to simplify common cases. - Being explicit about Content-Type header. - Cleaned up code flow - Cleaned up error handling and messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sendResponseandsendErrorResponseto simplify common cases.This also reverts the change that made returned values explicit from version 3.7.0. That change didn't actually improve the snyk reports. Being explicit about the Content-Type header was the trick 👍🏼